Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated target to netstandard2.0 #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Updated target to netstandard2.0 #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/NetMQ.Security/NetMQ.Security.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>netstandard1.6</TargetFramework>
<TargetFramework>netstandard2.0</TargetFramework>
<AssemblyName>NetMQ.Security</AssemblyName>
<AssemblyOriginatorKeyFile>../../NetMQ.snk</AssemblyOriginatorKeyFile>
<SignAssembly>true</SignAssembly>
Expand Down
3 changes: 1 addition & 2 deletions src/NetMQ.Security/V0_1/HandshakeLayer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,7 @@ public HandshakeLayer(SecureChannel secureChannel, ConnectionEnd connectionEnd)
CipherSuite.TLS_RSA_WITH_AES_128_CBC_SHA
};

#warning This method is not available in .NETStandard 1.6 - planned for 2.0; using X509Chain for now as it has the same functionality in NetFx, where X509Certificate2.Verify() calls the same internal method as X509Chain().Build(c)
VerifyCertificate = c => new X509Chain().Build(c); //c.Verify();
VerifyCertificate = c => c.Verify();
}

public SecurityParameters SecurityParameters { get; }
Expand Down
2 changes: 1 addition & 1 deletion tests/NetMQ.Security.Tests/NetMQ.Security.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>netcoreapp1.1</TargetFramework>
<TargetFramework>net481</TargetFramework>
<AssemblyName>NetMQ.Security.Tests</AssemblyName>
<AssemblyOriginatorKeyFile>../../NetMQ.snk</AssemblyOriginatorKeyFile>
<SignAssembly>true</SignAssembly>
Expand Down