Skip to content
This repository has been archived by the owner on Aug 23, 2022. It is now read-only.

bugs in the adv benchmark ? #17

Open
zjin-lcf opened this issue Nov 14, 2020 · 2 comments
Open

bugs in the adv benchmark ? #17

zjin-lcf opened this issue Nov 14, 2020 · 2 comments

Comments

@zjin-lcf
Copy link

Dumping the output of the adv benchmark shows that the results are different significantly for each run. Can you reproduce that ?

Thanks

@stgeke
Copy link
Contributor

stgeke commented Nov 14, 2020 via email

@zjin-lcf
Copy link
Author

zjin-lcf commented Nov 14, 2020

When a seed is used for initializing input data, the outputs still differ significantly for each run.

In addition, do you think the range is right for s_cubInterpT as shown below ? I am not familiar with your domain. Could you please provide a CPU reference implementation for comparison/verification ?

Thanks

"""
@shared dfloat s_cubD[p_cubNq][p_cubNq];
@shared dfloat s_cubInterpT[p_Nq][p_cubNq];

for(int j = 0; j < p_cubNq; ++j; @inner(1))
  for(int i = 0; i < p_cubNq; ++i; @inner(0)) {
    const int id = i + j * p_cubNq;
    if (id < p_Nq * p_cubNq)
      s_cubInterpT[0][id] = cubInterpT[id];  // s_cubInterpT[0][id]  where id ranges from 0 to  p_cubNq, not from 0 to p_Nq * p_cubNq

"""

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants