Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instruciton how to setup an env for developers #65

Open
paulromano opened this issue Mar 8, 2018 · 8 comments
Open

Add instruciton how to setup an env for developers #65

paulromano opened this issue Mar 8, 2018 · 8 comments

Comments

@paulromano
Copy link
Contributor

The quickstart documentation mentions an examples/ directory that doesn't seem to exist in the Nek5000 repo anymore (I gather those moved to the NekExamples repo). Along the same lines, the Running your first simulation doesn't work because there's no examples directory.

@dshaver-ANL
Copy link
Contributor

It's not an error. The examples directory is included in the tarball, but NOT on the github repo. The tarball is the recommended method of downloading the code. See issues #62 and #63 for further info.

All that being said, I will leave this issue open until the documentation is more clear on this.

@paulromano
Copy link
Contributor Author

Ah, my mistake. Nevertheless, people who are git-savvy are more likely to clone the repo than to download a tarball, so I agree making it clearer in the documentation that the instructions only work with tarballs would be a good idea.

@stgeke
Copy link
Contributor

stgeke commented Mar 9, 2018

Note, the tarball constains the nek source, examples, documentation (in the future) and all required 3rd party code. That's why we strongly recommend to always use the latest release which is only avaiable as a tarball. This is explained in the quick start:

All release tarballs can be found here. We do not recommend using the master branch on GitHub in a production environment!

Is this not clear enough?

@paulromano
Copy link
Contributor Author

It's perfectly clear if you take the time to read it :) Again, someone git-savvy will see the first section titled "Downloading the code" and may say to themselves "I know how to do that already". It wouldn't hurt to put a reminder in the "Running your first simulation" section.

@stgeke
Copy link
Contributor

stgeke commented Mar 9, 2018

Just want to point out that if you miss this important information you may run into other issues (incompatible 3rd party versions etc.).

@paulromano
Copy link
Contributor Author

Good to know. It might be worth having a separate developer's guide that discusses setting up a proper environment with git then for people who are interesting in contributing to the code and need to be working off the master branch.

@stgeke
Copy link
Contributor

stgeke commented Mar 9, 2018

I agree, that's a good idea!

@dshaver-ANL dshaver-ANL changed the title Examples in quickstart Developer's Guide Mar 18, 2018
@dshaver-ANL
Copy link
Contributor

Okay, I added some extra warnings about not trying to clone the master branch. I think the initial issue here is closed, but I'm going to change this to "developer's guide".

@stgeke stgeke changed the title Developer's Guide Add instruciton how to setup an env for developers May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants