Adds Character validation specs

Author: Nejuf

Gemfile

@@ -87,7 +87,6 @@ group :development, :test do
   gem 'faker'
   # gem 'jslint_on_rails'
   gem 'jshint_on_rails'
-  gem 'launchy'
   gem 'letter_opener'
   gem 'meta_request'
   gem 'rails-erd'
@@ -97,6 +96,8 @@ end
 
 group :test do
   gem 'capybara'
+  gem 'faker'
   gem 'guard-rspec'
+  gem 'launchy'
   gem 'shoulda-matchers'
 end

app/models/character.rb

@@ -6,7 +6,7 @@ class Character < ActiveRecord::Base
     presence: true
 
   validates :name, length: { in: 1..80 }
-  validates :name, uniqueness: { scope: :affinity_id }
+  validates :name, uniqueness: { scope: :series_id }
 
   validates  :stat_hp, :stat_str, :stat_def,
     :stat_spd, numericality: { only_integer: true, greater_than_or_equal_to: 0 }
@@ -89,6 +89,8 @@ def ensure_defaults
     self.stat_str ||= 0
     self.stat_def ||= 0
     self.stat_spd ||= 0
+    self.stat_int ||= 0
+    self.stat_luck ||= 0
   end
 
   def on_before_save

app/models/user.rb

@@ -7,7 +7,7 @@ class User < ActiveRecord::Base
          :recoverable, :rememberable, :trackable, :validatable,
          # :confirmable,
          :lockable, :omniauthable
-         #TODO uncomment confirmable before release
+         #TODO uncomment confirmable after exiting alpha release
  has_many :entries
  has_many :contests
  has_many :characters

spec/factories/characters.rb

@@ -2,14 +2,17 @@
 
 FactoryGirl.define do
   factory :character do
-    name "MyString"
-    desc "MyText"
-    user_id 1
-    affinity 1
-    tier_id 1
-    stat_hp 1
-    stat_str 1
-    stat_def 1
-    stat_spd 1
+    name { Faker::Name.name }
+    desc { "This character is shrouded in mystery...\nWhat potential lies in store?" }
+    user_id { 1 }
+    affinity_id { [1,2,3].sample }
+    tier_id { [1,2,3,4].sample }
+    series_id { nil }
+    stat_hp { (100*rand).floor }
+    stat_str { (100*rand).floor }
+    stat_def { (100*rand).floor }
+    stat_spd { (100*rand).floor }
+    stat_int { (100*rand).floor }
+    stat_luck { (100*rand).floor }
   end
 end

spec/models/character_spec.rb

@@ -1,5 +1,54 @@
 require 'spec_helper'
 
 describe Character do
-  pending "add some examples to (or delete) #{__FILE__}"
+	context 'validation' do 
+	  it 'has a valid factory' do
+	  	expect(FactoryGirl.create(:character)).to be_valid
+	  end
+
+	  it 'is invalid without a name' do
+	  	expect(FactoryGirl.build(:character, name: nil)).to_not be_valid
+	  end
+
+	  it 'is invalid if name is more than 80 characters' do
+	  	expect(FactoryGirl.build(:character, name: "as"*41)).to_not be_valid
+	  end
+
+	  it 'is invalid without an affinity' do
+	  	expect(FactoryGirl.build(:character, affinity_id: nil)).to_not be_valid
+	  end
+
+	  it 'is invalid without a tier' do
+	  	expect(FactoryGirl.build(:character, tier_id: nil)).to_not be_valid
+	  end
+
+	  it 'is invalid without stats' do
+	  	expect(FactoryGirl.build(:character, stat_hp: nil)).to_not be_valid
+	  	expect(FactoryGirl.build(:character, stat_str: nil)).to_not be_valid
+	  	expect(FactoryGirl.build(:character, stat_def: nil)).to_not be_valid
+	  	expect(FactoryGirl.build(:character, stat_spd: nil)).to_not be_valid
+	  	expect(FactoryGirl.build(:character, stat_int: nil)).to_not be_valid
+	  	expect(FactoryGirl.build(:character, stat_luck: nil)).to_not be_valid
+	  end
+
+	  it 'is invalid with stats than 0' do
+	  	expect(FactoryGirl.build(:character, stat_str: -1)).to_not be_valid
+	  end
+
+	  it 'is invalid with non-integer stats' do
+	  	expect(FactoryGirl.build(:character, stat_str: 1.5)).to_not be_valid
+	  end
+
+	  it 'is invalid when it shares a name with another character in the same series' do
+	  	bob1 = FactoryGirl.create(:character, name: "Bob", series_id: 1)
+	  	bob2 = FactoryGirl.build(:character, name: "Bob", series_id: 1)
+	  	expect(bob2).to_not be_valid
+	  end
+
+	  it 'is valid when it shares a name with another character in a different series' do
+	  	bob1 = FactoryGirl.create(:character, name: "Bob", series_id: 1)
+	  	bob2 = FactoryGirl.build(:character, name: "Bob", series_id: 2)
+	  	expect(bob2).to be_valid
+	  end
+	end
 end