Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*_withNotes.html files in GhidraDocs/GhidraClass do not work in GitHub HTML Preview #7442

Open
colinhowell opened this issue Feb 3, 2025 · 0 comments
Assignees
Labels
Feature: Documentation Status: Triage Information is being gathered

Comments

@colinhowell
Copy link

All of the *_withNotes.html files in the "GhidraDocs/GhidraClass" directory tree (the annotated tutorial versions of the slides for the Ghidra classes) fail to work in GitHub HTML Preview. They all fail in the same way. The versions without "_withNotes" work correctly.

I've tested this both with current Firefox and with current Chrome, and the failure is identical.

Go to the page https://htmlpreview.github.io/ and enter a URL for one of these files as requested. If you enter one of the normal pages, without "_withNotes", it works fine. For example, https://github.com/NationalSecurityAgency/ghidra/blob/master/GhidraDocs/GhidraClass/Beginner/Introduction_to_Ghidra_Student_Guide.html looks like (direct link if you don't want to do the form by hand):

Image

However, if you try to view https://github.com/NationalSecurityAgency/ghidra/blob/master/GhidraDocs/GhidraClass/Beginner/Introduction_to_Ghidra_Student_Guide_withNotes.html in this way, you get a failure screen that looks like (direct link):

Image

This same problem occurs for all the _withNotes files. I assume something about their code does not play nicely with Github HTML Preview.

Considering that one commenter on issue #2273 on these class files remarked, "As a single individual going through these slides why would you choose without notes?", the inability to view with notes is a bit of a downer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Documentation Status: Triage Information is being gathered
Projects
None yet
Development

No branches or pull requests

3 participants