Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make table component generic data type #3992

Open
mhenkens opened this issue Jan 16, 2025 · 0 comments
Open

Make table component generic data type #3992

mhenkens opened this issue Jan 16, 2025 · 0 comments
Assignees

Comments

@mhenkens
Copy link
Contributor

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[X] Bug report  
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

Actually the data type is object

Expected behavior

Generic type for data type

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

When migrating from stark 10 to stark 12 we receive compilation error from typescript. Those error could be solved using generic type instead of Object

Environment


Angular version: 12.0.0
Stark version: 12.0.0-alpha.0


Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
For Tooling issues:
- Node version: 14 
- Platform:  

Others:

@mhenkens mhenkens self-assigned this Jan 16, 2025
mhenkens added a commit to mhenkens/stark that referenced this issue Jan 16, 2025
use Generic type in `StarkTable` instead of `Object`

ISSUES CLOSED: NationalBankBelgium#3992
@mhenkens mhenkens mentioned this issue Jan 16, 2025
3 tasks
mhenkens added a commit to mhenkens/stark that referenced this issue Jan 21, 2025
use Generic type in `StarkTable` instead of `Object`

ISSUES CLOSED: NationalBankBelgium#3992
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant