Use Activator.CreateInstance to create default value types

Author: NathanBaulch

Saleslogix.SData.Client.Test/Content/ContentHelperTests.cs

@@ -575,6 +575,58 @@ public void Deserialize_Simple_Types_From_String_Test()
             Assert.That(result.UriProp, Is.EqualTo(new Uri("http://1.com")));
         }
 
+        [Test]
+        public void Deserialize_Simple_Types_From_Null_Test()
+        {
+            var value = new SDataResource
+                {
+                    {"SByteProp", null},
+                    {"ShortProp", null},
+                    {"IntProp", null},
+                    {"LongProp", null},
+                    {"ByteProp", null},
+                    {"UShortProp", null},
+                    {"UIntProp", null},
+                    {"ULongProp", null},
+                    {"FloatProp", null},
+                    {"DoubleProp", null},
+                    {"BoolProp", null},
+                    {"CharProp", null},
+                    {"DecimalProp", null},
+                    {"DateTimeProp", null},
+                    {"EnumProp", null},
+                    {"StringProp", null},
+                    {"DateTimeOffsetProp", null},
+                    {"GuidProp", null},
+                    {"TimeSpanProp", null},
+                    {"VersionProp", null},
+                    {"UriProp", null},
+                    {"ByteArrayProp", null}
+                };
+            var result = ContentHelper.Deserialize<Simple_Types_Object>(value);
+            Assert.That(result.SByteProp, Is.EqualTo(0));
+            Assert.That(result.ShortProp, Is.EqualTo(0));
+            Assert.That(result.IntProp, Is.EqualTo(0));
+            Assert.That(result.LongProp, Is.EqualTo(0));
+            Assert.That(result.ByteProp, Is.EqualTo(0));
+            Assert.That(result.UShortProp, Is.EqualTo(0));
+            Assert.That(result.UIntProp, Is.EqualTo(0));
+            Assert.That(result.ULongProp, Is.EqualTo(0));
+            Assert.That(result.FloatProp, Is.EqualTo(0));
+            Assert.That(result.DoubleProp, Is.EqualTo(0));
+            Assert.That(result.BoolProp, Is.False);
+            Assert.That(result.CharProp, Is.EqualTo('\0'));
+            Assert.That(result.DecimalProp, Is.EqualTo(0));
+            Assert.That(result.DateTimeProp, Is.EqualTo(DateTime.MinValue));
+            Assert.That(result.EnumProp, Is.EqualTo(DayOfWeek.Sunday));
+            Assert.That(result.StringProp, Is.EqualTo(null));
+            Assert.That(result.DateTimeOffsetProp, Is.EqualTo(DateTimeOffset.MinValue));
+            Assert.That(result.GuidProp, Is.EqualTo(Guid.Empty));
+            Assert.That(result.TimeSpanProp, Is.EqualTo(TimeSpan.Zero));
+            Assert.That(result.VersionProp, Is.EqualTo(null));
+            Assert.That(result.UriProp, Is.EqualTo(null));
+        }
+
         [Test]
         public void Serialize_Simple_Types_Test()
         {

Saleslogix.SData.Client/Content/ContentHelper.cs

@@ -496,7 +496,7 @@ public override object DeserializeObject(object value, Type type)
                 if (value == null)
                 {
                     return type.GetTypeInfo().IsValueType && !ReflectionUtils.IsNullableType(type)
-                        ? ConstructorCache[type]()
+                        ? Activator.CreateInstance(type)
                         : null;
                 }
 

Saleslogix.SData.Client/Properties/AssemblyInfo.cs

@@ -25,8 +25,8 @@
 // You can specify all the values or you can default the Build and Revision Numbers
 // by using the '*' as shown below:
 
-[assembly: AssemblyVersion("2.0.1.1547")]
-[assembly: AssemblyFileVersion("2.0.1.1547")]
+[assembly: AssemblyVersion("2.0.1.1548")]
+[assembly: AssemblyFileVersion("2.0.1.1548")]
 [assembly: NeutralResourcesLanguage("en-US")]
 [assembly: AssemblyInformationalVersion("2.0")]
 [assembly: InternalsVisibleTo("Saleslogix.SData.Client.Test, PublicKey=" +