Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect from the main page to the logged account page if logged in #68

Open
StephenLynx opened this issue May 6, 2021 · 5 comments
Open

Comments

@StephenLynx
Copy link

I registered an account with a password. Then I tested accessing the account directly by the uri. I was able to change stuff and save it to the server, when I logged in the changes were actually saved. Am I missing something here?

@StephenLynx StephenLynx changed the title goes password does anything? does the password does anything? May 6, 2021
@StephenLynx
Copy link
Author

nvm. I didn't noticed that the login screen didn't redirect you in case you were already logged in. So yeah, the password is working as intended, but I guess it would be handy to redirect users to the stats page if they land on the main page already logged in.

@Nasicus
Copy link
Owner

Nasicus commented May 7, 2021

the idea of the first screen is, that you can also enter another address there, not specify the password and get to the other players page in readonly mode. Also it allows you to create a new grail in case you want that.

@StephenLynx
Copy link
Author

StephenLynx commented May 7, 2021

What if instead there was a button to log out on your account page or a link to the page of your logged account on the login page? It just doesn't seem intuitive to me the main page doesn't give you any indication you are already logged in.

@Nasicus
Copy link
Owner

Nasicus commented May 7, 2021

agree that it's not intuitive at all... I'm open for a PR if you want, but for me personally it's not worth to implement this.

@StephenLynx StephenLynx changed the title does the password does anything? Redirect from the main page to the logged account page if logged in May 7, 2021
@StephenLynx
Copy link
Author

Ok, I'll edit the name then. I know node a lot, but I don't understand your framework or TS, but I'll submit a PR if I feel like learning it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants