New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to remove code duplication #27

Open

Nasicus opened this issue Jul 8, 2019 · 0 comments

Labels

party

Owner

Nasicus commented Jul 8, 2019 •

edited

Loading

Some stuff is now duplicated:

LoginForm
RegisterForm
LeftSideButtons
GrailErrorHandler
DbInitializer (index creators)
other? => check "all the code"

We should try to make common components with properties of them, so they can all be reused.

Note:
Only do 1 file / area per PullRequest - do not make them all in one!

Nasicus added the party label

Nasicus mentioned this issue

Adding the ability to Party Up! #24

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment