Streak broken?

[ljharb]

As of today or yesterday, "current streak" seems to only be calculating based on the visible squares.

For example, when i go to https://github.com/ljharb?tab=overview&from=2021-03-01&to=2021-03-25, it shows me a current streak of "0 days"; when i go to https://github.com/ljharb, it shows me a current streak of 369 days. Neither is correct.

[Naramsim]

Hi @ljharb, the streak is calculated backward starting from the rightest day. In your first example, the rightest day is Dec 31 2021, which isn't yet happened. So I guess it's normal we calculate 0 days for that example.

Regarding your second example, I see your current streak equal to 109 days. Take a look below:

On Dec 6 I don't have any contribution. On your calendar do you have contributions for Dec 6? Are those private?

[Naramsim]

If you had a full green calendar, then for you, @ljharb, the longest streak would have been calculated starting from 2020-03-22.

Does it seem right?

[Naramsim]

Anyway, I think that the ability Github implemented about checking past years and thus rendering the calendar, broke the extension in case someone had a very long streak.

[Naramsim]

Yeah, I thought about it. So, if you request through the UI a different time period && you had a full streak. Then your full-streak can be broken if in the new rendered calendar there are 'holes'. So to fix this behavior I need to only update our database (a Github gist) when the default view is shown to the user. That is when the query string of the URL doesn't contain any to or from.

I'll try to fix it as soon as possible. But I'm doing so many other things... I hope I can @ljharb

[ljharb]

Hmm - I definitely have contributions on that day, a PR review - on mine, the square shows filled in. Github does sometimes blank out days temporarily, i have no idea why.

Similarly, I have contributions on 2020-03-21 (also 2 PR reviews). My streak goes back to 2014.

Perhaps these anomalies are just on github's side.

[ljharb]

Thanks!

Contributions in the past can happen any time, but it seems reasonable to assume that anything more than a year old is "frozen", or at least cached aggressively.

[Naramsim]

Nono, those anomalies are on Github and they were reflected in our database.

Can you please write your starting date down? If you don't remember I have to dig it up, but it's possible. Anyway, up until Github doesn't show that square green, I can't update your longest streak.

[ljharb]

it's 2014-04-16.

[g-harel]

May be a separate thing, but I'm also seeing a much shorter streak than before. It's suspiciously stopping almost exactly a year ago on my profile.

[ljharb]

Today, a few days later, it's still saying my streak ends almost exactly a year ago. The implication is that it's not counting beyond a year anymore.

[Naramsim]

For you @ljharb this is the case. Because you have a hole in the calendar

[ljharb]

@Naramsim a hole that moves one day every day? Now it says it goes back to the 29th, and the (incorrect) hole you saw was on the 21st.

[spences10]

Same here, looks like it's only doing it for the last 366 days?

[Naramsim]

Hi @spences10 Yesterday I released on Chrome and FF a potential fix for the bug. In the meantime, I reverted your old start contribution date to what it was.

I believe that there are still browsers that are using the old version of this extension, and when one loads your profile it could change the starting date back to Apr 2020. I guess we need to wait a bit and see if the error still happens.

[spences10]

I'm using MS Edge, shall I try uninstall and reinstall?

[spences10]

I just installed the Chrome version and it's working now 😊

[ljharb]

@Naramsim how do i ensure the extension is updated? i'm still seeing 366 days back (i have v1.14.14)

[Naramsim]

@ljharb I updated your starting date but as soon as I updated it, it got reverted.

I'll try tomorrow. 1.14.14 is the latest version.

Also, your streak will only display for not logged-in users. I noted that the 'hole' is present if you are logged in and isn't any more present if you log out. Github itself has probably a bug in building the calendar.

[Naramsim]

I'm using MS Edge, shall I try uninstall and reinstall?

Hi @spences10, in Edge how do you install this extension? Is there a marketplace?

[ljharb]

@Naramsim in my specific case, i only ever view my streak as a logged-out user, for the exact reason that i want to see how others see it :-) github definitely has many such bugs at times.

Thanks, I'll try again tomorrow. How can i ensure that I have the newest version of the extension?

[Naramsim]

Chrome, in theory, auto-updates everything as soon as possible.

[ljharb]

@Naramsim any chance you could try resetting my start date now? :-)

[Naramsim]

@ljharb, I rolled out a new version, fixing the issue also for your profile.

I'd wait 1 or 2 days, sorry.

[ljharb]

Thanks! I’ll check in 48 hours, and I’ll try not to refresh that page in chrome until then :-)

[Naramsim]

Well, the chrome extension is already deployed. .15 is the newer version, you can check if it's installed by going to the 3-dots menu and select more tools -> extensions.

[ljharb]

I'm on that version - does that mean it's safe to refresh?

[Naramsim]

yes hahah

[ljharb]

yayyyyyy thank you!

[ljharb]

@Naramsim this seems to have happened again - it thinks i have no contributions on 2022.01.08, but github currently shows me having 19.

[Naramsim]

yes, we are aware of the issue over here: #89