Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] User tools is aggressive in reserving memory on large machines #1406

Closed
amahussein opened this issue Oct 31, 2024 · 0 comments · Fixed by #1407
Closed

[BUG] User tools is aggressive in reserving memory on large machines #1406

amahussein opened this issue Oct 31, 2024 · 0 comments · Fixed by #1407
Assignees
@amahussein
Labels
bug Something isn't working user_tools Scope the wrapper module running CSP, QualX, and reports (python)

Comments

@amahussein
Copy link
Collaborator

Describe the bug

It was noticed that the java process will be killed by the system; especially after we added the heap_min argument. This causes the tools runtime to be killed and we want to avoid that from happening on customer's side.

We should consider:

  • Using a smaller amount of memory or calculate the heap size based on the available/free memory instead of total memory.
  • Capping the number of threads to 3 is too conservative. We might want to do a different calculation.
@amahussein amahussein added ? - Needs Triage bug Something isn't working user_tools Scope the wrapper module running CSP, QualX, and reports (python) labels Oct 31, 2024
@amahussein amahussein self-assigned this Oct 31, 2024
amahussein added a commit to amahussein/spark-rapids-tools that referenced this issue Oct 31, 2024
@amahussein
Reduce default memory allocation to the java process
f9874dd 
Signed-off-by: Ahmed Hussein <[email protected]>

Fixes NVIDIA#1406
@amahussein amahussein mentioned this issue Oct 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amahussein amahussein

Labels
bug Something isn't working user_tools Scope the wrapper module running CSP, QualX, and reports (python)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reduce default memory allocation to the java process amahussein/spark-rapids-tools
1 participant
@amahussein