fix: release ci process

Author: lockwobr

.github/workflows/cli-release.yaml

@@ -15,7 +15,6 @@
 # limitations under the License.
 
 # Build and release CLI binaries when cli/* tags are pushed
-# Uses GoReleaser for cross-platform builds (standard for kubectl plugins)
 name: CLI Release
 
 on:
@@ -34,9 +33,6 @@ jobs:
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4
-        with:
-          fetch-depth: 0
-          fetch-tags: true
 
       - name: Setup Go ${{ env.GO_VERSION }}
         uses: actions/setup-go@v5
@@ -47,18 +43,49 @@ jobs:
       - name: Extract version from tag
         id: version
         run: |
-          # Tag is cli/v0.9.0, extract v0.9.0
-          VERSION=$(echo "${{ github.ref_name }}" | cut -f 2 -d /)
+          # Tag is cli/v0.1.0, extract v0.1.0
+          VERSION="${GITHUB_REF_NAME#cli/}"
           echo "version=${VERSION}" >> $GITHUB_OUTPUT
           echo "Building CLI version: ${VERSION}"
 
-      - name: Run GoReleaser
-        uses: goreleaser/goreleaser-action@v6
+      - name: Build CLI binaries
+        working-directory: operator
+        run: make cli-release-build CLI_VERSION=${{ steps.version.outputs.version }}
+
+      - name: Create GitHub Release
+        uses: softprops/action-gh-release@v2
         with:
-          distribution: goreleaser
-          version: "~> v2"
-          args: release --clean
-          workdir: operator
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          GORELEASER_CURRENT_TAG: ${{ steps.version.outputs.version }}
+          tag_name: ${{ github.ref_name }}
+          name: "Skyhook CLI ${{ steps.version.outputs.version }}"
+          files: |
+            operator/dist/*.tar.gz
+            operator/dist/*.zip
+            operator/dist/checksums.txt
+          body: |
+            ## Skyhook CLI ${{ steps.version.outputs.version }}
+
+            ### Installation
+
+            Download and extract the appropriate archive for your platform.
+            The binary must be named `kubectl-skyhook` for kubectl to discover it as a plugin.
+            Alternatively, it can be used directly as `skyhook` without kubectl.
+
+            ```bash
+            # Linux (amd64)
+            curl -LO https://github.com/NVIDIA/skyhook/releases/download/${{ github.ref_name }}/skyhook_${{ steps.version.outputs.version }}_linux_amd64.tar.gz
+            tar -xzf skyhook_${{ steps.version.outputs.version }}_linux_amd64.tar.gz
+            sudo mv skyhook /usr/local/bin/kubectl-skyhook
+
+            # macOS (Apple Silicon)
+            curl -LO https://github.com/NVIDIA/skyhook/releases/download/${{ github.ref_name }}/skyhook_${{ steps.version.outputs.version }}_darwin_arm64.tar.gz
+            tar -xzf skyhook_${{ steps.version.outputs.version }}_darwin_arm64.tar.gz
+            sudo mv skyhook /usr/local/bin/kubectl-skyhook
+            ```
+
+            ### Verify installation
+
+            ```bash
+            kubectl skyhook version --client-only
+            # Or if installed as 'skyhook':
+            skyhook version --client-only
+            ```

.github/workflows/operator-ci.yaml

@@ -20,8 +20,12 @@ name: Operator CI
 on:
   workflow_dispatch: {}
   pull_request:
-    paths:
-      - operator/**
+    paths: &operator-paths
+      - operator/**/*.go
+      - operator/go.mod
+      - operator/go.sum
+      - operator/deps.mk
+      - operator/config/**
       - containers/operator.Dockerfile
       - .github/workflows/operator-ci.yaml
       - k8s-tests/**
@@ -31,12 +35,7 @@ on:
       - main
     tags:
       - operator/*
-    paths:
-      - operator/**/*.go
-      - containers/operator.Dockerfile
-      - .github/workflows/operator-ci.yaml
-      - k8s-tests/**
-      - chart/**
+    paths: *operator-paths
 
 ## these envs control the build and test process below
 env:

operator/.goreleaser.yaml

@@ -38,6 +38,7 @@ endif
 
 GIT_SHA 		:= $(shell git rev-parse --short HEAD)
 GIT_TAG_LAST 	:= $(shell git tag --list 'operator*' --sort=-v:refname | head -n 1 | cut -d/ -f2)
+CLI_TAG_LAST 	:= $(shell git tag --list 'cli/*' --sort=-v:refname | head -n 1 | cut -d/ -f2)
 
 ## GO Flags
 GO_LDFLAGS  := -ldflags "-X github.com/NVIDIA/skyhook/operator/internal/version.GIT_SHA=$(GIT_SHA) \
@@ -337,6 +338,40 @@ CLI_LDFLAGS := -ldflags "-X github.com/NVIDIA/skyhook/operator/internal/version.
 build-cli: ensure-test-symlinks ## Build CLI binary.
 	go build $(GOFLAGS) $(CLI_LDFLAGS) -o bin/skyhook cmd/cli/main.go
 
+CLI_VERSION ?= $(CLI_TAG_LAST)
+CLI_DIST_DIR ?= dist
+cli-release-build: ## Build CLI binaries for all platforms (used by CI release workflow).
+	@echo "Building CLI $(CLI_VERSION) for all platforms..."
+	@mkdir -p $(CLI_DIST_DIR)
+	@# Build for each platform
+	@for os in linux darwin windows; do \
+		for arch in amd64 arm64; do \
+			echo "  Building $$os/$$arch..."; \
+			ext=""; if [ "$$os" = "windows" ]; then ext=".exe"; fi; \
+			GOOS=$$os GOARCH=$$arch CGO_ENABLED=0 go build $(GOFLAGS) \
+				-ldflags "-X github.com/NVIDIA/skyhook/operator/internal/version.VERSION=$(CLI_VERSION) -X github.com/NVIDIA/skyhook/operator/internal/version.GIT_SHA=$(GIT_SHA)" \
+				-o $(CLI_DIST_DIR)/skyhook_$(CLI_VERSION)_$${os}_$${arch}$${ext} cmd/cli/main.go; \
+		done; \
+	done
+	@# Create archives (rename binary to just "skyhook" inside archive)
+	@echo "Creating archives..."
+	@cd $(CLI_DIST_DIR) && for os in linux darwin; do \
+		for arch in amd64 arm64; do \
+			cp skyhook_$(CLI_VERSION)_$${os}_$${arch} skyhook && \
+			tar -czf skyhook_$(CLI_VERSION)_$${os}_$${arch}.tar.gz skyhook && \
+			rm skyhook; \
+		done; \
+	done
+	@cd $(CLI_DIST_DIR) && for arch in amd64 arm64; do \
+		cp skyhook_$(CLI_VERSION)_windows_$${arch}.exe skyhook.exe && \
+		zip -q skyhook_$(CLI_VERSION)_windows_$${arch}.zip skyhook.exe && \
+		rm skyhook.exe; \
+	done
+	@# Generate checksums
+	@echo "Generating checksums..."
+	@cd $(CLI_DIST_DIR) && shasum -a 256 *.tar.gz *.zip > checksums.txt
+	@echo "Done! Artifacts in $(CLI_DIST_DIR)/"
+
 build-cli-with-coverage: ensure-test-symlinks ## Build CLI binary with coverage instrumentation.
 	go build $(GOFLAGS) -cover $(CLI_LDFLAGS) -o bin/skyhook-cover cmd/cli/main.go
 	@# Ensure bin/skyhook exists (copy from cover binary if not cached) so symlinks work