Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [QST] Regression - why Sm90RowBroadcast in 3.5.1 stops support smem usage? #2010

Open
ankutalev opened this issue Dec 23, 2024 · 5 comments
Labels
? - Needs Triage bug Something isn't working

Comments

@ankutalev
Copy link

ankutalev commented Dec 23, 2024

Hello!
The question is in the title, proofs

3.5.0
3.5.1

I'm interested in this change, because it breaks backward compatibility and seems suspicious.
Can you provide some details about this change?

Thanks!

Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@ankutalev
Copy link
Author

This issue still needs to be addressed

@thakkarV
Copy link
Collaborator

@jackkosaian @hwu36 CC

@hwu36
Copy link
Collaborator

hwu36 commented Jan 23, 2025

Also CC @richardmcai

@richardmcai
Copy link

The static assert comment is inaccurate, if you look at the implementation you see that it does use shared memory. Stage count is still required to be 0 since we no longer pipeline the row vector load across epilogue iterations and instead load it all at once into smem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
? - Needs Triage bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants