-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] wmma should be enabled w/ clang. #2006
Comments
This needs to be fixed in a few more places: diff --git a/include/cutlass/arch/wmma.h b/include/cutlass/arch/wmma.h
--- a/include/cutlass/arch/wmma.h
+++ b/include/cutlass/arch/wmma.h
@@ -34,9 +34,6 @@
#pragma once
-// CUTLASS WMMA does not support clang at present.
-#if !(defined(__clang__) && defined(__CUDA__))
-
#if (__CUDACC_VER_MAJOR__ >= 9)
#if (!defined(__CUDA_ARCH__) || (__CUDA_ARCH__ >= 700))
#define CUTLASS_ARCH_WMMA_ENABLED
@@ -58,8 +55,6 @@
#endif
#endif
-#endif //!(defined(__clang__) && defined(__CUDA__))
-
#if defined(CUTLASS_ARCH_WMMA_ENABLED)
#include <mma.h>
diff --git a/include/cutlass/epilogue/warp/fragment_iterator_wmma_tensor_op.h b/include/cutlass/epilogue/warp/fragment_iterator_wmma_tensor_op.h
--- a/include/cutlass/epilogue/warp/fragment_iterator_wmma_tensor_op.h
+++ b/include/cutlass/epilogue/warp/fragment_iterator_wmma_tensor_op.h
@@ -43,8 +43,6 @@
#pragma once
-#if !(defined(__clang__) && defined(__CUDA__))
-
#include "third_party/gpus/cutlass/include/cutlass/wmma_array.h"
#include "third_party/gpus/cutlass/include/cutlass/layout/matrix.h"
@@ -158,7 +156,3 @@ public:
////////////////////////////////////////////////////////////////////////////////
-#else
-#error (defined(__clang__) && defined(__CUDA__))
-#endif // !defined(__clang__)
-
diff --git a/include/cutlass/epilogue/warp/tile_iterator_wmma_tensor_op.h b/include/cutlass/epilogue/warp/tile_iterator_wmma_tensor_op.h
--- a/include/cutlass/epilogue/warp/tile_iterator_wmma_tensor_op.h
+++ b/include/cutlass/epilogue/warp/tile_iterator_wmma_tensor_op.h
@@ -34,8 +34,6 @@
#pragma once
-#if !(defined(__clang__) && defined(__CUDA__))
-
#include "third_party/gpus/cutlass/include/cutlass/cutlass.h"
#include "third_party/gpus/cutlass/include/cutlass/wmma_array.h"
#include "third_party/gpus/cutlass/include/cutlass/layout/matrix.h"
@@ -223,5 +221,3 @@ public:
/////////////////////////////////////////////////////////////////////////////////////////////////
-#endif // !defined(__clang__)
- |
This issue has been labeled |
ping. |
Describe the bug
cutlass currently disables WMMA instructions when compiled with clang.
cutlass/include/cutlass/arch/wmma.h
Lines 37 to 38 in e1cd8c7
The comment is no longer valid and the tests work fine with the condition above removed.
Steps/Code to reproduce bug
Build test/unit/gemm/warp/gemm_sm75.cu with clang and run it on A100. Currently the test fils with:
Expected behavior
With the condition above removed, the tests work fine:
The text was updated successfully, but these errors were encountered: