Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all CUB dispatchers into internal namespaces #3094

Open
Tracked by #101
bernhardmgruber opened this issue Dec 9, 2024 · 2 comments
Open
Tracked by #101

Move all CUB dispatchers into internal namespaces #3094

bernhardmgruber opened this issue Dec 9, 2024 · 2 comments

Comments

@bernhardmgruber
Copy link
Contributor

bernhardmgruber commented Dec 9, 2024

From previous discussions with @gevtushenko I concluded that we don't want users to target the CUB dispatch layer directly. We should therefore move them into internal namespaces and add aliases in their place. Those aliases can be deprecated in the future once #1186 lands.

@jrhemstad
Copy link
Collaborator

jrhemstad commented Dec 11, 2024

As a note, I don't think we can fully remove these until we have a replacement user-defined tuning API in place in our public APIs. Otherwise we'll pull out the dispatch layer and people won't have anything else to replace it with.

@bernhardmgruber
Copy link
Contributor Author

I don't think we can fully remove these until we have a replacement user-defined tuning API

I am aware, which is why I did not put a deprecation warning on the alias in the public namespace yet. I made that clear in the description. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

2 participants