Skip to content

Commit 36f379f

Browse files
authored
[skip-test] Fix merge conflict from two inflight PRs (#338)
We renamed `TEST_COMPILER_C1XX` to `TEST_COMPILER_MSVC` because the former does not make sense and the latter is the convention we have for the internal macro However, an inflight PR did miss the macro rename Skipping tests as this is only libcudacxx test related
1 parent d70a624 commit 36f379f

File tree

6 files changed

+20
-20
lines changed

6 files changed

+20
-20
lines changed

libcudacxx/.upstream-tests/test/std/iterators/iterator.requirements/alg.req.ind.copy/indirectly_copyable_storable.compile.pass.cpp

+6-6
Original file line numberDiff line numberDiff line change
@@ -158,42 +158,42 @@ struct DeletedCopyCtor {
158158
DeletedCopyCtor& operator=(DeletedCopyCtor const&) = default;
159159
};
160160

161-
#if TEST_STD_VER > 17 || !defined(TEST_COMPILER_C1XX) // multiple versions of a defaulted special member functions are not allowed
161+
#if TEST_STD_VER > 17 || !defined(TEST_COMPILER_MSVC) // multiple versions of a defaulted special member functions are not allowed
162162
struct DeletedNonconstCopyCtor {
163163
DeletedNonconstCopyCtor(DeletedNonconstCopyCtor const&) = default;
164164
DeletedNonconstCopyCtor(DeletedNonconstCopyCtor&) = delete;
165165
DeletedNonconstCopyCtor& operator=(DeletedNonconstCopyCtor const&) = default;
166166
};
167167
static_assert(!cuda::std::indirectly_copyable_storable<DeletedNonconstCopyCtor*, DeletedNonconstCopyCtor*>);
168-
#endif // TEST_STD_VER > 17 || !defined(TEST_COMPILER_C1XX)
168+
#endif // TEST_STD_VER > 17 || !defined(TEST_COMPILER_MSVC)
169169

170170
struct DeletedMoveCtor {
171171
DeletedMoveCtor(DeletedMoveCtor&&) = delete;
172172
DeletedMoveCtor& operator=(DeletedMoveCtor&&) = default;
173173
};
174174

175-
#if TEST_STD_VER > 17 || !defined(TEST_COMPILER_C1XX) // multiple versions of a defaulted special member functions are not allowed
175+
#if TEST_STD_VER > 17 || !defined(TEST_COMPILER_MSVC) // multiple versions of a defaulted special member functions are not allowed
176176
struct DeletedConstMoveCtor {
177177
DeletedConstMoveCtor(DeletedConstMoveCtor&&) = default;
178178
DeletedConstMoveCtor(DeletedConstMoveCtor const&&) = delete;
179179
DeletedConstMoveCtor& operator=(DeletedConstMoveCtor&&) = default;
180180
};
181181
static_assert(!cuda::std::indirectly_copyable_storable<DeletedConstMoveCtor*, DeletedConstMoveCtor*>);
182-
#endif // TEST_STD_VER > 17 || !defined(TEST_COMPILER_C1XX)
182+
#endif // TEST_STD_VER > 17 || !defined(TEST_COMPILER_MSVC)
183183

184184
struct DeletedCopyAssignment {
185185
DeletedCopyAssignment(DeletedCopyAssignment const&) = default;
186186
DeletedCopyAssignment& operator=(DeletedCopyAssignment const&) = delete;
187187
};
188188

189-
#if TEST_STD_VER > 17 || !defined(TEST_COMPILER_C1XX) // multiple versions of a defaulted special member functions are not allowed
189+
#if TEST_STD_VER > 17 || !defined(TEST_COMPILER_MSVC) // multiple versions of a defaulted special member functions are not allowed
190190
struct DeletedNonconstCopyAssignment {
191191
DeletedNonconstCopyAssignment(DeletedNonconstCopyAssignment const&) = default;
192192
DeletedNonconstCopyAssignment& operator=(DeletedNonconstCopyAssignment const&) = default;
193193
DeletedNonconstCopyAssignment& operator=(DeletedNonconstCopyAssignment&) = delete;
194194
};
195195
static_assert(!cuda::std::indirectly_copyable_storable<DeletedNonconstCopyAssignment*, DeletedNonconstCopyAssignment*>);
196-
#endif // TEST_STD_VER > 17 || !defined(TEST_COMPILER_C1XX)
196+
#endif // TEST_STD_VER > 17 || !defined(TEST_COMPILER_MSVC)
197197

198198
struct DeletedMoveAssignment {
199199
DeletedMoveAssignment(DeletedMoveAssignment&&) = default;

libcudacxx/.upstream-tests/test/std/iterators/iterator.requirements/iterator.concepts/incrementable.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -102,9 +102,9 @@ struct postinc_not_declared {
102102
using difference_type = int;
103103

104104
__host__ __device__ postinc_not_declared& operator++();
105-
#if defined(TEST_COMPILER_C1XX) // MSVC complains about "single-argument function used for postfix "++" (anachronism)""
105+
#if defined(TEST_COMPILER_MSVC) // MSVC complains about "single-argument function used for postfix "++" (anachronism)""
106106
__host__ __device__ postinc_not_declared& operator++(int) = delete;
107-
#endif // TEST_COMPILER_C1XX
107+
#endif // TEST_COMPILER_MSVC
108108
};
109109

110110
struct incrementable_with_difference_type {

libcudacxx/.upstream-tests/test/std/iterators/iterator.requirements/iterator.concepts/iterator.concept.bidir/bidirectional_iterator.compile.pass.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -144,9 +144,9 @@ struct no_postdecrement {
144144
__host__ __device__ no_postdecrement operator++(int);
145145

146146
__host__ __device__ no_postdecrement& operator--();
147-
#if defined(TEST_COMPILER_C1XX) // single-argument function used for postfix "--" (anachronism)
147+
#if defined(TEST_COMPILER_MSVC) // single-argument function used for postfix "--" (anachronism)
148148
__host__ __device__ no_postdecrement& operator--(int) = delete;
149-
#endif // TEST_COMPILER_C1XX
149+
#endif // TEST_COMPILER_MSVC
150150

151151
#if TEST_STD_VER > 17
152152
bool operator==(no_postdecrement const&) const = default;

libcudacxx/.upstream-tests/test/std/iterators/iterator.requirements/iterator.concepts/iterator.concept.input/input_iterator.compile.pass.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -58,11 +58,11 @@ struct not_weakly_incrementable {
5858

5959
__host__ __device__ int operator*() const;
6060

61-
#if defined(TEST_COMPILER_C1XX) // nvbug4119179
61+
#if defined(TEST_COMPILER_MSVC) // nvbug4119179
6262
__host__ __device__ void operator++(int);
6363
#else
6464
__host__ __device__ not_weakly_incrementable& operator++();
65-
#endif // TEST_COMPILER_C1XX
65+
#endif // TEST_COMPILER_MSVC
6666
};
6767
static_assert(!cuda::std::input_or_output_iterator<not_weakly_incrementable> &&
6868
!cuda::std::input_iterator<not_weakly_incrementable>);

libcudacxx/.upstream-tests/test/support/test_iterators.h

+4-4
Original file line numberDiff line numberDiff line change
@@ -1019,9 +1019,9 @@ struct Proxy {
10191019
return *this;
10201020
}
10211021

1022-
#if defined(TEST_COMPILER_C1XX)
1022+
#if defined(TEST_COMPILER_MSVC)
10231023
TEST_NV_DIAG_SUPPRESS(1805) // MSVC complains that if we pass a pointer type, adding const is useless
1024-
#endif // TEST_COMPILER_C1XX
1024+
#endif // TEST_COMPILER_MSVC
10251025

10261026
// const assignment required to make ProxyIterator model cuda::std::indirectly_writable
10271027
_LIBCUDACXX_TEMPLATE(class Other)
@@ -1032,9 +1032,9 @@ TEST_NV_DIAG_SUPPRESS(1805) // MSVC complains that if we pass a pointer type, ad
10321032
return *this;
10331033
}
10341034

1035-
#if defined(TEST_COMPILER_C1XX)
1035+
#if defined(TEST_COMPILER_MSVC)
10361036
TEST_NV_DIAG_DEFAULT(1805)
1037-
#endif // TEST_COMPILER_C1XX
1037+
#endif // TEST_COMPILER_MSVC
10381038

10391039
// If `T` is a reference type, the implicitly-generated assignment operator will be deleted (and would take precedence
10401040
// over the templated `operator=` above because it's a better match).

libcudacxx/libcxx/test/support/test_iterators.h

+4-4
Original file line numberDiff line numberDiff line change
@@ -1036,9 +1036,9 @@ struct Proxy {
10361036
return *this;
10371037
}
10381038

1039-
#if defined(TEST_COMPILER_C1XX)
1039+
#if defined(TEST_COMPILER_MSVC)
10401040
TEST_NV_DIAG_SUPPRESS(1805) // MSVC complains that if we pass a pointer type, adding const is useless
1041-
#endif // TEST_COMPILER_C1XX
1041+
#endif // TEST_COMPILER_MSVC
10421042

10431043
// const assignment required to make ProxyIterator model std::indirectly_writable
10441044
_LIBCUDACXX_TEMPLATE(class Other)
@@ -1049,9 +1049,9 @@ TEST_NV_DIAG_SUPPRESS(1805) // MSVC complains that if we pass a pointer type, ad
10491049
return *this;
10501050
}
10511051

1052-
#if defined(TEST_COMPILER_C1XX)
1052+
#if defined(TEST_COMPILER_MSVC)
10531053
TEST_NV_DIAG_DEFAULT(1805)
1054-
#endif // TEST_COMPILER_C1XX
1054+
#endif // TEST_COMPILER_MSVC
10551055

10561056
// If `T` is a reference type, the implicitly-generated assignment operator will be deleted (and would take precedence
10571057
// over the templated `operator=` above because it's a better match).

0 commit comments

Comments
 (0)