Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[common/PyTorch] Add FusedAttention support for SWA (left, right) #1369

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

cyanguwa
Copy link
Collaborator

@cyanguwa cyanguwa commented Dec 12, 2024

Description

This PR adds SWA (left, right) support to the FusedAttention backend for {bshd, sbhd, thd} formats and {no_mask, causal, causal_bottom_right, padding, padding_causal, padding_causal_bottom_right} masks.

Previously, the support was only for SWA (left, 0), {bshd, sbhd} formats, and {causal} mask.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refractor

Changes

Please list the changes introduced in this PR:

  • Adds FusedAttention support for SWA (left, right)

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@cyanguwa cyanguwa marked this pull request as ready for review December 15, 2024 02:07
@cyanguwa
Copy link
Collaborator Author

/te-ci pytorch L0

@cyanguwa cyanguwa changed the title [common/PyTorch] Add support for SWA (left,0) + padding + CM/BRCM [common/PyTorch] Add support for SWA (left,right) Dec 16, 2024
@cyanguwa cyanguwa changed the title [common/PyTorch] Add support for SWA (left,right) [common/PyTorch] Add support for SWA (left, right) Dec 16, 2024
@cyanguwa cyanguwa changed the title [common/PyTorch] Add support for SWA (left, right) [common/PyTorch] Add FusedAttention support for SWA (left, right) Dec 16, 2024
@cyanguwa cyanguwa marked this pull request as draft December 17, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant