Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a good default validation batch size or find a way to disable it #167

Open
Kipok opened this issue Oct 7, 2024 · 0 comments
Open

Set a good default validation batch size or find a way to disable it #167

Kipok opened this issue Oct 7, 2024 · 0 comments

Comments

@Kipok
Copy link
Collaborator

Kipok commented Oct 7, 2024

In the training scripts, we often ignore the validation values and instead do checkpoint averaging + periodic evaluation that's scheduled externally and runs in trtllm. If that is the case, the validation that nemo does is just wasting compute, but it's not possible to disable it currently. The best way is to fix it on nemo/nemo-aligner side so that we can just disable it. But if not, let's at least set the minimum possible validation batch size by default, which is something like mbs * dp size (might be a bit different if more involved parallelism is used)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant