Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize text_field, id_field, etc. terminology #342

Open
sarahyurick opened this issue Oct 30, 2024 · 0 comments
Open

Standardize text_field, id_field, etc. terminology #342

sarahyurick opened this issue Oct 30, 2024 · 0 comments
Assignees

Comments

@sarahyurick
Copy link
Collaborator

As I've worked on several NeMo Curator functionalities, I've been a bit annoyed that our parameter names aren't consistent across different modules.

For example, text_field, input_text_field, text_column, text_column_name, input_json_text_field, dataset_text_field, input_field, input_json_field, etc. all mean the same thing semantically lol. Let's standardize it to just text_field.

Same with id_field and possibly others.

@sarahyurick sarahyurick self-assigned this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant