Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-Wmissing-braces warns in nvtx3.hpp #112

Open
bdice opened this issue Feb 11, 2025 · 2 comments
Open

-Wmissing-braces warns in nvtx3.hpp #112

bdice opened this issue Feb 11, 2025 · 2 comments
Milestone

Comments

@bdice
Copy link
Collaborator

bdice commented Feb 11, 2025

I am compiling nvtx3.hpp with -Wmissing-braces and I get warnings in these locations:

/home/coder/rmm/build/conda/cuda-12.8/release/_deps/nvtx3-src/c/include/nvtx3/nvtx3.hpp:1930:9: error: suggest braces around initialization of subobject [-Werror,-Wmissing-braces]
 1930 |         0,                              // payload value (union)
      |         ^
      |         {}
/home/coder/rmm/build/conda/cuda-12.8/release/_deps/nvtx3-src/c/include/nvtx3/nvtx3.hpp:1932:9: error: suggest braces around initialization of subobject [-Werror,-Wmissing-braces]
 1932 |         0                               // message value (union)
      |         ^
      |         {}

I'm getting this when compiling for IWYU, which uses clang under the hood.

@bdice
Copy link
Collaborator Author

bdice commented Feb 11, 2025

See also: #109.

@evanramos-nvidia
Copy link
Collaborator

Already fixed on the dev branch in commit 81b27a3.

@evanramos-nvidia evanramos-nvidia added this to the v3.1.1 milestone Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants