Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Health check #240

Open
Nintorac opened this issue Feb 28, 2022 · 3 comments
Open

Health check #240

Nintorac opened this issue Feb 28, 2022 · 3 comments
Assignees
Labels
question Further information is requested

Comments

@Nintorac
Copy link
Contributor

Nintorac commented Feb 28, 2022

Not sure how this will look like. Total gRPC noob, sorry.

I am trying to stand up a FL server in AWS ECS behind a load balancer, to do so requires the service has a health check and that the health check responds healthy to health probes.

Here is the CDK object I need to configure that defines how the health check is performed.

And here is gRPC docs on health checking.

Is there
a) already a health check, if so how should I configure the cdk Health Check
b) if not already existing is there some workaround that I can use in the meantime

Thanks!

@Nintorac
Copy link
Contributor Author

Nintorac commented Mar 1, 2022

I have got this working using the /fedlearn.FederatedTraining/Heartbeat path and accepting 0-99 response code as a success.

Is there a more specific number/range that indicates a healthy hearbeat or would it be better to implement a specific endpoint for health checks?

@YuanTingHsieh YuanTingHsieh added the question Further information is requested label Mar 1, 2022
@holgerroth
Copy link
Collaborator

@yhwen, @nvidianz any comments on this one?

@nvidianz
Copy link
Collaborator

You can simply use TCP as the protocol and just check if the port is open. This works in all cases, even in TLS pass-thru mode. Heartbeat doesn't provide any more information on server's health.

We have plans to add real health check endpoint in the future releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

5 participants