Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow drag&drop job folder into admin console #1328

Open
holgerroth opened this issue Feb 9, 2023 · 1 comment
Open

Allow drag&drop job folder into admin console #1328

holgerroth opened this issue Feb 9, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@holgerroth
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
In Ubuntu, when dragging a folder containing the job config into the terminal running the admin console, it adds '-quotes to the filename. This causes an error when trying to submit the job:

> submit_job '/home/hroth/Code2/nvflare/splitnn/examples/cifar10/cifar10-splitnn/job_configs/cifar10_splitnn'
'/tmp/nvflare/poc/admin/startup/../transfer/'/home/hroth/Code2/nvflare/splitnn/examples/cifar10/cifar10-splitnn/job_configs/cifar10_splitnn'' is not a valid folder.

The '-quotes have to be manually deleted for the submit to work.

Describe the solution you'd like
Allow the file path including '-quotes (maybe also "-quotes) to be submitted.

Describe alternatives you've considered
n/a

Additional context
n/a

@holgerroth holgerroth added the enhancement New feature or request label Feb 9, 2023
@nvkevlu
Copy link
Collaborator

nvkevlu commented Dec 2, 2024

I can look into this. We could parse the value and remove the single quotes if detected, but it seems that single quotes are actually valid characters in directory and file names, at least on Ubuntu, so I will see what to do for this handling this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants