refactor: Replace custom maxFloat64 function with lo.Max from samber/lo for improved readability in timeaware tests

Author: gshaibi

test/e2e/suites/timeaware/timeaware_test.go

@@ -21,6 +21,7 @@ import (
 	"github.com/NVIDIA/KAI-scheduler/test/e2e/modules/wait"
 	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
+	"github.com/samber/lo"
 	v1 "k8s.io/api/core/v1"
 	"k8s.io/apimachinery/pkg/api/resource"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
@@ -107,7 +108,7 @@ var _ = Describe("Time Aware Fairness", Label("timeaware", "nightly"), Ordered,
 			values, qErr := queryPrometheusInstant(ctx, testCtx.KubeClientset, fmt.Sprintf("kai_queue_allocated_gpus{queue_name=\"%s\"}", queueA.Name))
 			g.Expect(qErr).NotTo(HaveOccurred())
 			g.Expect(values).NotTo(BeEmpty(), "Expected Prometheus to return at least one sample for queue-a")
-			g.Expect(maxFloat64(values)).To(BeNumerically(">=", float64(idleGPUs)), "Expected queue-a to be allocating all idle GPUs")
+			g.Expect(lo.Max(values)).To(BeNumerically(">=", float64(idleGPUs)), "Expected queue-a to be allocating all idle GPUs")
 		}, prometheusUsageTimeout, 5*time.Second).Should(Succeed())
 
 		By("Submitting a competing job from queue-b (requires reclaim to schedule)")

test/e2e/suites/timeaware/utils.go

@@ -66,16 +66,3 @@ func queryPrometheusInstant(ctx context.Context, kubeClient kubernetes.Interface
 	}
 	return values, nil
 }
-
-func maxFloat64(values []float64) float64 {
-	if len(values) == 0 {
-		return 0
-	}
-	max := values[0]
-	for _, v := range values[1:] {
-		if v > max {
-			max = v
-		}
-	}
-	return max
-}