Add a dump option to dump a fusion IR graph #3603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naoyam
commented
Dec 17, 2024
Comment on lines
+116
to
+121
| {"fusion_ir_concretized", DebugDumpOption::FusionIrConcretized}, | ||
| {"fusion_ir_graph", DebugDumpOption::FusionIrGraph}, | ||
| {"fusion_ir_math", DebugDumpOption::FusionIrMath}, | ||
| {"fusion_ir_original", DebugDumpOption::FusionIrOriginal}, | ||
| {"fusion_ir_presched", DebugDumpOption::FusionIrPresched}, | ||
| {"fusion_ir_preseg", DebugDumpOption::FusionIrPreseg}, |
There was a problem hiding this comment.
Just changed to the alphabetical ordering
|
!build |
wujingyue
approved these changes
Dec 17, 2024
| @@ -304,6 +305,9 @@ void KernelExecutor::compile( | |||
| NVF_ERROR( | |||
| !fusion->outputs().empty(), "No output found for this kernel, aborting."); | |||
|
|
|||
| createKernelId( | |||
There was a problem hiding this comment.
Remove
Fuser/csrc/runtime/executor.cpp
Lines 421 to 422 in d623221
There was a problem hiding this comment.
I just moved it here.
I also am not sure if this should be a stateful operation. It seems just returning a string seems sufficient, but didn't bother to do a further cleanup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NVFUSER_DUMP=fusion_ir_graphsaves the dot representation of a fusion before lowering to a file named like__tmp_fusion_ir_graph_inner_persistent_f0_c1_r0_g0.dot.Example visualization: #3498 (comment)