Complete type annotations #227
Conversation
SnoopJ
force-pushed
the
typing/gh214_finish-wrapper-types
branch
from
8eb3b90
to
55d9801
Compare
SnoopJ
force-pushed
the
typing/gh214_finish-wrapper-types
branch
from
55d9801
to
2c27d60
Compare
|
Thanks for adding all of these in! We made a couple of changes when sprinting today that will cause a couple merge conflicts here (sorry!) We also decided to make the geospatial-like dependencies optional and then just rely on the |
|
No trouble at all on the merge conflicts, I'll sort them out. Guarding/quoting the geospatial stuff sounds pretty straightforward to take care of. It turned out that I didn't have much time today, but I did get a few moments to look at the problems with the annotation of the |
Closes #214
This changeset adds a bunch of missing annotations and other fixes/workarounds to get
routee-compassto a complete set of annotations (i.e.mypy --strictcan be run over the whole wrapper with no errors). This also updates and re-enables the type-checking step of the test workflow (and adds the necessary type stubs to the[dev]extra)