You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
the implementation is somewhat messy. the resource management of creating progress bars and printing a final newline is leaked to the user of read_utils methods via a callback:
there's two spots in the edge rtree input plugin that don't give us good progress bar behavior:
loading the road class file doesn't have a progress bar
read_linestring_text_file doesn't call a final println!() to force a newline once the progress bar finishes; whatever is printed next overwrites the progress bar in stdout
a few things could be done here:
move progress bar instantiation inside of read_utils operations, make optional via function args (pb_title: Option<String>)
- without disrupting the availability of a row_callback: type RowCallback<'a, T> = Option<Box<dyn FnMut(&T) + 'a>>
- updating all call sites in the repo so we are creating file loading progress bars
create a newline at the end of geo_io_utils::read_linestring_text_file
review: are there other big O(n) operations during instantiation of Compass, like creating an rtree, that are missing a progress bar?
The text was updated successfully, but these errors were encountered:
Compass runs are more informative with progress bars. For example, users get a heads up while the graph and geometries are loaded:
the implementation is somewhat messy. the resource management of creating progress bars and printing a final newline is leaked to the user of read_utils methods via a callback:
there's two spots in the edge rtree input plugin that don't give us good progress bar behavior:
println!()
to force a newline once the progress bar finishes; whatever is printed next overwrites the progress bar in stdouta few things could be done here:
pb_title: Option<String>
)- without disrupting the availability of a
row_callback: type RowCallback<'a, T> = Option<Box<dyn FnMut(&T) + 'a>>
- updating all call sites in the repo so we are creating file loading progress bars
The text was updated successfully, but these errors were encountered: