Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some more ruby documentation #1855

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Some more ruby documentation #1855

merged 2 commits into from
Oct 11, 2024

Conversation

shorowit
Copy link
Contributor

@shorowit shorowit commented Oct 11, 2024

Pull Request Description

Addresses #1759. Completes ruby documentation for xmlhelper.rb, misc_loads.rb, and lighting.rb. And some light code cleanup.

Checklist

Not all may apply:

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@shorowit shorowit self-assigned this Oct 11, 2024
@shorowit shorowit merged commit 5e5b1fb into master Oct 11, 2024
7 checks passed
@shorowit shorowit deleted the more_ruby_doc branch October 11, 2024 23:46
@joseph-robertson joseph-robertson mentioned this pull request Oct 14, 2024
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant