Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HeatingPerformanceDataPoint.delete method #1854

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Fix HeatingPerformanceDataPoint.delete method #1854

merged 2 commits into from
Oct 11, 2024

Conversation

shorowit
Copy link
Contributor

@shorowit shorowit commented Oct 11, 2024 •
edited
Loading

Pull Request Description

Spotted by @joseph-robertson. Most likely we aren't using the method right now or we would have hit an issue with it.

Checklist

Not all may apply:

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@shorowit shorowit added the bug Something isn't working label Oct 11, 2024
@shorowit shorowit self-assigned this Oct 11, 2024
@shorowit shorowit merged commit 73460f9 into master Oct 11, 2024
@shorowit shorowit deleted the fix_delete branch October 11, 2024 15:57
@joseph-robertson joseph-robertson mentioned this pull request Oct 14, 2024
Merged
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@shorowit shorowit

Labels
bug Something isn't working
Projects
OpenStudio-HPXML
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shorowit