Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New CFIS VentilationOnlyModeAirflowFraction input #1041

Merged
merged 2 commits into from
Apr 19, 2022

Conversation

shorowit
Copy link
Contributor

@shorowit shorowit commented Apr 18, 2022

Pull Request Description

Closes #1018 and addresses #1029. For CFIS systems, allows an optional extension/VentilationOnlyModeAirflowFraction input (default: 1.0) to address duct losses during ventilation only mode. Uses the same modeling approach as was available in BEopt.

Checklist

PR Author: Check these when they're done. Not all may apply. strikethrough and check any that do not apply.

PR Reviewer: Verify each has been completed.

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (via tasks.rb)
  • Unit tests have been added/updated (e.g., HPXMLtoOpenStudio/tests)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • Checked the code coverage report on CI
  • No unexpected changes to simulation results of sample files

…rflowFraction` input to address duct losses during ventilation only mode.
@shorowit shorowit self-assigned this Apr 18, 2022
@shorowit shorowit marked this pull request as ready for review April 19, 2022 20:06
@shorowit shorowit merged commit 5c9b501 into master Apr 19, 2022
@shorowit shorowit deleted the cfis-airflow-fraction branch April 19, 2022 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate CFIS duct model
1 participant