Skip to content

Commit 7c3a84a

Browse files
committed
fix bug for vehicles in the reporting measures
1 parent 32e567b commit 7c3a84a

File tree

1 file changed

+10
-3
lines changed

1 file changed

+10
-3
lines changed

ReportSimulationOutput/measure.rb

+10-3
Original file line numberDiff line numberDiff line change
@@ -765,7 +765,6 @@ def get_outputs(runner, args)
765765
# Remove EV battery discharging
766766
@model.getElectricLoadCenterStorageLiIonNMCBatterys.each do |elcs|
767767
next unless elcs.additionalProperties.getFeatureAsString('is_ev')
768-
769768
fuel.annual_output += get_report_variable_data_annual([elcs.name.to_s.upcase], ['Electric Storage Discharge Energy']) if fuel_type == FT::Elec
770769
end
771770

@@ -778,6 +777,13 @@ def get_outputs(runner, args)
778777
# We add Electric Storage onto the timeseries Electricity fuel meter
779778
elec_storage_timeseries_output = get_report_meter_data_timeseries(['ElectricStorage:ElectricityProduced'], UnitConversions.convert(1.0, 'J', fuel.timeseries_units), 0, args[:timeseries_frequency])
780779
fuel.timeseries_output = fuel.timeseries_output.zip(elec_storage_timeseries_output).map { |x, y| x - y }
780+
781+
# Remove timeseries EV battery discharging
782+
@model.getElectricLoadCenterStorageLiIonNMCBatterys.each do |elcs|
783+
next unless elcs.additionalProperties.getFeatureAsString('is_ev')
784+
ev_discharge_timeseries_output = get_report_variable_data_timeseries([elcs.name.to_s.upcase], ['Electric Storage Discharge Energy'], UnitConversions.convert(1.0, 'J', fuel.timeseries_units), 0, args[:timeseries_frequency])
785+
fuel.timeseries_output = fuel.timeseries_output.zip(ev_discharge_timeseries_output).map { |x, y| x + y }
786+
end
781787
end
782788

783789
# Peak Electricity Consumption
@@ -1480,7 +1486,8 @@ def check_for_errors(runner, outputs)
14801486
@fuels => 'Fuel',
14811487
@emissions => 'Emissions',
14821488
@loads => 'Load',
1483-
@component_loads => 'Component Load' }.each do |outputs, output_type|
1489+
@component_loads => 'Component Load',
1490+
@vehicles => 'Vehicles' }.each do |outputs, output_type|
14841491
outputs.each do |key, obj|
14851492
next if obj.timeseries_output.empty?
14861493

@@ -2816,7 +2823,7 @@ def get_timeseries_units_from_fuel_type(fuel_type)
28162823
@vehicles[VT::VehicleDischarging] = Vehicles.new(variables: get_object_outputs(VT, VT::VehicleDischarging))
28172824
@vehicles.each do |vehicles_type, vehicle_data|
28182825
vehicle_data.name = "Vehicle: #{vehicles_type}"
2819-
vehicle_data.annual_units = 'Mbtu'
2826+
vehicle_data.annual_units = 'MBtu'
28202827
vehicle_data.timeseries_units = 'kWh'
28212828
end
28222829

0 commit comments

Comments
 (0)