Added DSE=1 for Room AC #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnblonsky
reviewed
Sep 4, 2024
| @@ -123,8 +123,11 @@ def __init__(self, envelope_model=None, use_ideal_capacity=None, **kwargs): | |||
| self.duct_dse = ducts.get('DSE (-)') # Duct distribution system efficiency | |||
| self.duct_zone = self.envelope_model.zones.get(ducts.get('Zone')) | |||
| if self.duct_dse is None: | |||
| # Calculate DSE using ASHRAE 152 | |||
| self.duct_dse = utils_equipment.calculate_duct_dse(self, ducts, **kwargs) | |||
| if self.name == 'Room AC': | |||
There was a problem hiding this comment.
I think we could add some more exceptions here. If ducts are in a conditioned basement, I think we can skip the 152 calculation too, right @jmaguire1? Any other things we should catch based on the bad DSE runs?
jmaguire1
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DSE is set to 1 for Room AC
Fixes #99