Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Battery Module does not work #121

Open
phaniarvind opened this issue May 6, 2024 · 1 comment
Open

Battery Module does not work #121

phaniarvind opened this issue May 6, 2024 · 1 comment

Comments

@phaniarvind
Copy link

The battery does not seem to work properly in the developer version of the package. With default inputs or manual input or with either control type the battery does not charge or discharge. The state of the battery does not change throughout the whole simulation and remains at the initial state. The battery mode is also always "Off" seemingly.

Attached is screenshot of my code. Here I am running the battery only.
image

Here are the equipment arguments for the dwelling.
image

The battery module does work in the stable release version of the package but as noted in a prior issue the PV doesn't. In the stable version the battery charges & discharges as per the schedule with the given parameters.

Any help is appreciated.

@mnblonsky
Copy link
Collaborator

I confirmed that the battery model works, it's just our documentation isn't up to date. control_type is no longer an input. You'll need to add:

'Battery': {
    'self_consumption_mode': True,
}

That is equivalent to setting control_type to 'Self-consumption' in the past. If you want to implement the 'Schedule' control, you need to either add a time series schedule with a column of Battery Electric Power (kW), or set the Battery power at each time step using P Setpoint. See the tutorial notebook for some examples.

We'll keep this issue open until we fix the documentation, but that may take some time. A couple of tasks for that:

  • Remove control_type to docs
  • Add self_consumption_mode to docs
  • Add new Battery schedule column names to docs
  • Add examples with Battery schedule in run_equipment and notebook

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants