Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Std. 62.1 VRP calculations for Secondary Recirculation Systems #10775

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Fix Std. 62.1 VRP calculations for Secondary Recirculation Systems #10775

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46ef789
fix errors in VRP calculations for zone design terms for secondary re…
EnergyArchmage Sep 30, 2024
a960bf8
Merge remote-tracking branch 'remotes/origin/develop' into 10774-std-…
mjwitte Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/EnergyPlus/SizingManager.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1341,23 +1341,23 @@ void ManageSystemVentilationAdjustments(EnergyPlusData &state)
Real64 Ez_Clg = thisTermUnitFinalZoneSizing.ZoneADEffCooling; // user input in Zone Air Distribution design spec object
Real64 Fc_Clg = 1.0 - (1.0 - Ez_Clg) * (1.0 - Er) * (1 - Ep_Clg);
state.dataSize->FcByZoneCool(termUnitSizingIndex) = Fc_Clg;
state.dataSize->EvzByZoneCool(termUnitSizingIndex) =
(Fa_Clg + state.dataSize->XsBySysCool(AirLoopNum) * Fb_Clg - state.dataSize->ZdzClgByZone(termUnitSizingIndex) * Fc_Clg) /
Fa_Clg;
state.dataSize->EvzByZoneCool(termUnitSizingIndex) = (Fa_Clg + state.dataSize->XsBySysCool(AirLoopNum) * Fb_Clg -
state.dataSize->ZdzClgByZone(termUnitSizingIndex) * Ep_Clg * Fc_Clg) /
Fa_Clg;
// note that SimAirServingZones::LimitZoneVentEff is intended only for single path per I/O ref

// find Evz for heating
Real64 Ep_Htg = thisTermUnitFinalZoneSizing.ZonePrimaryAirFractionHtg; // as adjusted in ManageSystemSizingAdjustments();
Real64 Fa_Htg = Ep_Htg + (1.0 - Ep_Htg) * Er;
state.dataSize->FaByZoneHeat(termUnitSizingIndex) = Fa_Htg;
Real64 Fb_Htg = Ep_Htg;
state.dataSize->FbByZoneCool(termUnitSizingIndex) = Fb_Htg;
state.dataSize->FbByZoneHeat(termUnitSizingIndex) = Fb_Htg;
Real64 Ez_Htg = thisTermUnitFinalZoneSizing.ZoneADEffHeating; // user input in Zone Air Distribution design spec object
Real64 Fc_Htg = 1.0 - (1.0 - Ez_Htg) * (1.0 - Er) * (1 - Ep_Htg);
state.dataSize->FcByZoneHeat(termUnitSizingIndex) = Fc_Htg;
state.dataSize->EvzByZoneHeat(termUnitSizingIndex) =
(Fa_Htg + state.dataSize->XsBySysHeat(AirLoopNum) * Fb_Htg - state.dataSize->ZdzHtgByZone(termUnitSizingIndex) * Fc_Htg) /
Fa_Htg;
state.dataSize->EvzByZoneHeat(termUnitSizingIndex) = (Fa_Htg + state.dataSize->XsBySysHeat(AirLoopNum) * Fb_Htg -
state.dataSize->ZdzHtgByZone(termUnitSizingIndex) * Ep_Htg * Fc_Htg) /
Fa_Htg;

} else { // 62.1 ventilation rate procedure - single path zone
state.dataSize->EvzByZoneCool(termUnitSizingIndex) =
Expand Down
Loading