Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the use of bats in testing #221

Closed
underwoo opened this issue Nov 26, 2019 · 4 comments · Fixed by #228
Closed

Remove the use of bats in testing #221

underwoo opened this issue Nov 26, 2019 · 4 comments · Fixed by #228
Labels
enhancement Issue/PR for a modification that increases performance, improves syntax, or adds functionality. help wanted
Milestone

Comments

@underwoo
Copy link
Member

Is your feature request related to a problem? Please describe.
The Bash Automated Testing System (bats is currently used to produce TAP style output. Using bats adds an additional requirement in order for a user to test the build of FMS, especially since bats is not a base package installed by *nix OSes. We would like to have bats removed from the testing scripts for libFMS.

Describe the solution you'd like
Ideally, we would like to have a solution that would preserve the TAP output, but we understand that may be difficult as it may introduce a dependency on some other utility. Thus, we would like some basic solution that will work with both the test harness system built into both GNU Autotools and CMake build systems.

@underwoo underwoo added the enhancement Issue/PR for a modification that increases performance, improves syntax, or adds functionality. label Nov 26, 2019
@edwardhartnett
Copy link
Contributor

I would propose to solve this with the solution I describe in #169.

Regular sh shell scripts can be used to run tests, as is done in netcdf-c, netcdf-fortran, HDF5, PIO, and other packages. Since sh is standard on all unix systems this is maximally portable. These scripts are then run from Makefile.am and CMakeLists.txt files. (See netcdf-c for good examples.)

@underwoo
Copy link
Member Author

Your proposal in #169 is sufficient.

@edwardhartnett
Copy link
Contributor

Actually the TAP style output is not a problem for the shell scripts, so we can keep that.

@edwardhartnett
Copy link
Contributor

OK, actually TAP style output is a huge pain. So I will jettison that desirement...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue/PR for a modification that increases performance, improves syntax, or adds functionality. help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants