Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FMS-fregrid consolidation I: remove mosaic directory #1618

Open
mlee03 opened this issue Dec 3, 2024 · 1 comment · May be fixed by #1626
Open

FMS-fregrid consolidation I: remove mosaic directory #1618

mlee03 opened this issue Dec 3, 2024 · 1 comment · May be fixed by #1626
Assignees
@mlee03
Labels
enhancement Issue/PR for a modification that increases performance, improves syntax, or adds functionality.

Comments

@mlee03
Copy link
Contributor

mlee03 commented Dec 3, 2024

Is your feature request related to a problem? Please describe.
In FMS, the mosaic directory contains C files that were brought over from FRE-NCTools. Many of the functions defined in these C files are unused or are obsolete. In addition, these functions are used by mosaic2_mod and horiz_interp_mod and provide more than just mosaic-related support. The directory name is thus misleading.

Describe the solution you'd like

  1. Clean up the C files
  2. Rename the mosaic directory to a more fitting name such as grid_utils (TBD)
  3. Update the C functions with current versions from FRE-NCTools

Describe alternatives you've considered
Leave as is.

Additional context
This change is part of FMSgridtools development where create_xgrid functions from FRE-NCTools/fregrid will be relocated to FMS and horiz_interp_mod will become the sole regridding tool supported by MSD
@mlee03 mlee03 added the enhancement Issue/PR for a modification that increases performance, improves syntax, or adds functionality. label Dec 3, 2024
@mlee03 mlee03 self-assigned this Dec 3, 2024
@mlee03 mlee03 changed the title Remove mosaic directory FMS-fregrid consolidation I: remove mosaic directory Dec 3, 2024
@rem1776
Copy link
Contributor

rem1776 commented Dec 3, 2024 •
edited
Loading

@mlee03 I think this is basically a duplicate of #1344, so we should probably close one of these. Which one to close is up to you.

This was referenced Dec 3, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mlee03 mlee03

Labels
enhancement Issue/PR for a modification that increases performance, improves syntax, or adds functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

mosaic cleanup and rename to grid_utils mlee03/FMS
2 participants
@rem1776 @mlee03