Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up public interfaces in field_manager_mod and other modules #1244

Open
mlee03 opened this issue Jun 5, 2023 · 2 comments · May be fixed by #1317
Open

Clean up public interfaces in field_manager_mod and other modules #1244

mlee03 opened this issue Jun 5, 2023 · 2 comments · May be fixed by #1317
Labels
enhancement Issue/PR for a modification that increases performance, improves syntax, or adds functionality.

Comments

@mlee03
Copy link
Contributor

mlee03 commented Jun 5, 2023

Is your feature request related to a problem? Please describe.
The module procedures within an interface are declared as public along with the interface in field_manager and fm_util . For example,

public test
public test_integer
public test_real

interface  test
  module procedure test_integer
  module procedure test_real
end interface test 

The above should be

public test
interface  test
  module procedure test_integer
  module procedure test_real
end interface test 

Describe the solution you'd like
Cleanup of the interfaces in FMS

Describe alternatives you've considered

Additional context
In order to make FMS more perfect

@mlee03 mlee03 added the enhancement Issue/PR for a modification that increases performance, improves syntax, or adds functionality. label Jun 5, 2023
@thomas-robinson
Copy link
Member

Are test_real and test_integer routines that was recently added? How do we know that no one is calling them?

@mlee03
Copy link
Contributor Author

mlee03 commented Jun 8, 2023

It seems like none of the model components call test_real and test_integer, i.e, ocean_BGC calls fm_get_value not fm_get_value_real, etc.

@mlee03 mlee03 linked a pull request Aug 3, 2023 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue/PR for a modification that increases performance, improves syntax, or adds functionality.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants