Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be able to handle point output if point/grid mismatch because -180 to 180 vs 0 to 360 #1273

Closed
JessicaMeixner-NOAA opened this issue Jul 17, 2024 · 4 comments · Fixed by #1325
Assignees
Labels
enhancement New feature or request

Comments

@JessicaMeixner-NOAA
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
As reported by @NickSzapiro-NOAA here: ufs-community/ufs-weather-model#2368

One can run into issues where point output and the grids do not match because they are defined by -180 to 180 vs 0 to 360 for one or the other.

Describe the solution you'd like
Solutions posed by @NickSzapiro-NOAA here: ufs-community/ufs-weather-model#2368

Describe alternatives you've considered

While the first solution is a great immediate solution, ideally we should enhance WW3 so that this is a non-issue.

Additional context
Add any other context or screenshots about the feature request here.

@JessicaMeixner-NOAA
Copy link
Collaborator Author

FYI - Starting to work on this, by updating https://github.com/NOAA-EMC/WW3/blob/develop/model/src/w3triamd.F90#L1604

@JessicaMeixner-NOAA
Copy link
Collaborator Author

Branch with potential fix is here: https://github.com/JessicaMeixner-NOAA/WW3/tree/bug/points180360 working to confirm that differences in standalone WW3 regression tests are as expected and testing in GFS set-up before submitting PR.

@DeniseWorthen
Copy link
Contributor

@JessicaMeixner-NOAA Is this updated in the dev/ufs-weather-model branch yet?

@JessicaMeixner-NOAA
Copy link
Collaborator Author

Not yet... should be next commit after the next batch which is all non-answer changing though. That PR should be submitted to UFS using this WW3 PR #1381 soon and I'm already working on the PR for this bug fix to follow, which is the next commit in develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging a pull request may close this issue.

2 participants