Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark AddNLog-methods as obsolete and instead redirect to AddNLogWeb #668

Open
snakefoot opened this issue Jun 10, 2021 · 1 comment
Open

Mark AddNLog-methods as obsolete and instead redirect to AddNLogWeb #668

snakefoot opened this issue Jun 10, 2021 · 1 comment
Labels
ASP.NET Core ASP.NET Core - all versions breaking change
Milestone
6.0

Comments

@snakefoot
Copy link
Contributor

snakefoot commented Jun 10, 2021 •
edited
Loading

Keep users from thinking that they need to call both:

builder.AddNLog()
builder.AddNLogWeb()

Avoid naming confusion with extension-methods from NLog.Extensions.Logging. Making it easier to explain users that they should always use AddNLogWeb() for ASP.NET Core applications.
@snakefoot snakefoot added this to the 5.0 milestone Jun 10, 2021
@snakefoot snakefoot mentioned this issue Jun 10, 2021
Merged
@snakefoot snakefoot modified the milestones: 5.0, 6.0 Aug 30, 2021
@snakefoot snakefoot mentioned this issue May 10, 2022
Closed
@snakefoot snakefoot added the ASP.NET Core ASP.NET Core - all versions label Dec 29, 2022
@bakgerman
Copy link
Contributor

bakgerman commented Aug 6, 2023 •
edited
Loading

Completed this in a branch until ready for merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ASP.NET Core ASP.NET Core - all versions breaking change
Projects
None yet
Milestone
6.0
Development

No branches or pull requests
2 participants
@bakgerman @snakefoot