-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fix for issue #1289 #1291
Bug fix for issue #1289 #1291
Conversation
Fix the issue of no wood product when forced by area-based harvest. NGEET#1289
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me!
biogeochem/EDLoggingMortalityMod.F90
Outdated
@@ -291,7 +291,7 @@ subroutine LoggingMortality_frac( pft_i, dbh, canopy_layer, lmort_direct, & | |||
! transfer of area to secondary land is based on overall area affected, not just logged crown area | |||
! l_degrad accounts for the affected area between logged crowns | |||
if(prt_params%woody(pft_i) == itrue)then ! only set logging rates for trees | |||
if (cur_harvest_tag == 0) then | |||
if (cur_harvest_tag == 0 .or. cur_harvest_tag == 2) then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HI @sshu88 -- would it be possible to replace these integers that you are comparing cur_harvest_tag
to, here and elsewhere, with named integer constants that describe more clearly what these conditions refer to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice suggestion! I updated the code.
Use named integer constants for "harvest_tag"
Define named constants for "harvest_tag"
Regression testing underway on derecho. |
Two-stream singularity correction update This implements a more comprehensive avoidance of singularities with two-stream radiation across bands.
Regression testing is showing b4b results for all expected tests. Note that the relevant test for this fix Results: |
Testing the Results: |
Fix the issue of no wood product when forced by area-based harvest. #1289
Description:
Collaborators:
Expectation of Answer Changes:
Checklist
If this is your first time contributing, please read the CONTRIBUTING document.
All checklist items must be checked to enable merging this pull request:
Contributor
Integrator
Documentation
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: