Logging direct mort condition check bug

[XiulinGao]

fates/biogeochem/EDLoggingMortalityMod.F90

Line 346 in 08f2410

if (cur_harvest_tag == 0) then

I was running the logging module with area-based logging approach and found no direct mortality at all. I tracked down to this line of code. As for area-based logging, cur_harvest_tag is set to 2, thus there will never be direct logging mortality resulted from it.

fates/biogeochem/EDLoggingMortalityMod.F90

Line 283 in 08f2410

cur_harvest_tag = 2

this condition check should be (cur_harvest_tag .eq. 0 .or. cur_harvest_tag .eq. 2).

[sshu88]

This tag was designed to be 0 for C-based harvest if biomass match the demand or area-based harvest. Later I have changed this to 2 for area-based harvest thus it can bypass some of the harvest debt calculation in patch dynamics. Thanks for the correction. Will contact others and submit PR for correction.

[glemieux]

Btw, @XiulinGao are you using e3sm or ctsm for this? I ask as I found an e3sm-side issue that impacts running in this mode: E3SM-Project/E3SM#6806

[XiulinGao]

@glemieux I am using ctsm, and I did not run into the harvest mode issue.