Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a test to verify that latest StateVersion is applied to new contract deployments #71

Open
petersalomonsen opened this issue Oct 24, 2023 · 0 comments

Comments

@petersalomonsen
Copy link
Collaborator

In order to prevent the scenario described in #69 to happen again, we should introduce a test to verify that the new method of lib.rs initialize the contract with the latest StateVersion.

Without such a test it is very likely that developers will break the migration test again because of forgetting to update the StateVersion also for new contract deployments.

The consequence of breaking the migration test is first of all that it's blocking PRs that follows.

@petersalomonsen petersalomonsen changed the title Introduce a test to verify that latest StateVersion is applied to new contract deployemtns Introduce a test to verify that latest StateVersion is applied to new contract deployemnts Oct 24, 2023
@petersalomonsen petersalomonsen changed the title Introduce a test to verify that latest StateVersion is applied to new contract deployemnts Introduce a test to verify that latest StateVersion is applied to new contract deployments Oct 24, 2023
@Tguntenaar Tguntenaar self-assigned this Dec 19, 2023
@Tguntenaar Tguntenaar removed their assignment Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants