Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/shared types #154

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Feature/shared types #154

wants to merge 6 commits into from

Conversation

Tguntenaar
Copy link
Collaborator

Resolves #153

Published a crate here: https://crates.io/crates/devhub-shared
Included the crate here: https://github.com/Tguntenaar/devhub-cache-api

@Tguntenaar
Copy link
Collaborator Author

@race-of-sloths include

@race-of-sloths-bot
Copy link

@Tguntenaar Thank you for your contribution! Your pull request is now a part of the Race of Sloths!

Shows inviting banner with latest news.

Shows profile picture for the author of the PR

Current status: waiting for scoring

We're waiting for maintainer to score this pull request with @race-of-sloths score [0,1,2,3,5,8,13] command. Alternatively, autoscoring [1,2] will be applied for this pull request

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@Tguntenaar Tguntenaar marked this pull request as ready for review October 10, 2024 16:52
@petersalomonsen
Copy link
Collaborator

@race-of-sloths score 13

Finding a replacement for the indexer is critical and has been a huge effort. My score is not only for the content in this PR, but also for all the efforts needed to get here.

@race-of-sloths
Copy link

race-of-sloths commented Oct 13, 2024 •
edited
Loading

@Tguntenaar Thank you for your contribution! Your pull request is now a part of the Race of Sloths!

Shows inviting banner with latest news.

Shows profile picture for the author of the PR

Current status: stale

This pull request was removed from the race, but you can include it again with @race-of-sloths include command

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

petersalomonsen
petersalomonsen reviewed Oct 13, 2024
View reviewed changes
Copy link
Collaborator

@petersalomonsen petersalomonsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would request a bit more coverage in the migration test. I can see we are adding community and proposals, but not RFP for example. I would also feel safer if we had tests on editing RFPs / Proposal after migration.

@Tguntenaar
Copy link
Collaborator Author

Tguntenaar commented Oct 27, 2024 •
edited
Loading

Thanks for the review and comments! Before making further edits to this PR, I think we should discuss how we want to manage this shared folder as a team. For now, the crate is sufficient, so we can proceed with the API. We can revisit type management once we’ve replaced the indexer on the frontend.

@Tguntenaar
Copy link
Collaborator Author

I came across this message in the NEAR Dev Community: https://t.me/neardev/58522 . I thought it might add some value to discussions in this PR.

@race-of-sloths
Copy link

❌ PR inactive

This PR has been inactive for two weeks. It's now marked as stale.

Tip

If you think it's a mistake, you can restart the bot with include command to proceed 🔄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petersalomonsen petersalomonsen petersalomonsen left review comments

@frol frol Awaiting requested review from frol

@PolyProgrammist PolyProgrammist Awaiting requested review from PolyProgrammist

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extract Proposal and Rfp types into a shared crate
4 participants
@Tguntenaar @race-of-sloths-bot @petersalomonsen @race-of-sloths