Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update leaflet to CRAN #304

Closed
DanWismer opened this issue Apr 4, 2023 · 1 comment
Closed

update leaflet to CRAN #304

DanWismer opened this issue Apr 4, 2023 · 1 comment
Labels
sometime Feature that might be good to incorporate eventually, but not a priority

Comments

@DanWismer
Copy link
Contributor

DanWismer commented Apr 4, 2023 •
edited
Loading

There is no leaflet::updateMapPane or leaflet::addRasterImage option to include a pane on the CRAN version of leaflet.

If all fails, we could rename our NCC-CNC/leaflet repo to NCC-CNC/leafletncc. That way when users remotes::install_github("NCC-CNC/wheretowork") our ncc version of leaflet won't overwrite the users CRAN version of leaflet on their system libraries.

This is part of an effort to update our wtw package dependencies to reflect the latest and greatest CRAN versions
@DanWismer DanWismer added the sometime Feature that might be good to incorporate eventually, but not a priority label Apr 4, 2023
@DanWismer
Copy link
Contributor Author

We updated the forked version of leaflet

PR #380

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
sometime Feature that might be good to incorporate eventually, but not a priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DanWismer