Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should agree on Qualifier policies to guide implementation of TRAPI 1.3 #76

Open
edeutsch opened this issue Jul 11, 2022 · 1 comment

Comments

@edeutsch
Copy link
Collaborator

As we all implement TRAPI 1.3, I think it would be very helpful to document our common answers to these questions:

  1. If a client does not specify qualifiers in a query, but a server has edges that match the requested predicate but with qualifiers on them, SHOULD/MUST it furnish those qualifiers to the client?

  2. If a client does specify qualifiers in a query, but a server has only edges that match the unqualified predicate (or doesn't implement qualifiers at all yet), SHOULD/MUST the server return the matching unqualified edges or nothing?

I think we should discuss and document these policies. I think this is a job for Architecture, but maybe it more apropos for another group?

@edeutsch
Copy link
Collaborator Author

I had forgotten that we had already voted on question 2 over in the TRAPI repo here: NCATSTranslator/ReasonerAPI#328

The results (with a 4-1-0 vote) seems to be:

If a KP receives non-empty QEdge.qualifier_constraints, it MAY return edges that satisfy the unqualified edge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant