Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatch in redundant information between suites, cases, and assets #90

Open
sierra-moxon opened this issue Jun 28, 2024 · 2 comments
Open

Comments

@sierra-moxon
Copy link
Member

After some investigation, we have a Case/Asset mismatch in the main branch that is causing this strangeness with my replacement of "MONDO:0008345".

TestCase_32 in sprint_4_tests.json is "what affects CHEBI:167574" with "semaglutide" in the answers
Tests/test_suites/sprint_4_tests.json

TestCase_32 in semantic_smoke_test_suite_PROD.json is "what treats MONDO:0008345", "Pirfenidone treats Idiopathic pulmonary fibrosis" https://github.com/NCATSTranslator/Tests/blob/414b240ca84cb3d64e09650b55d1bf133ad299c0/test_suites/semantic_smoke_test_suite_TEST.json#L16066

TestCase_32 itself in test_cases/TestCase_32.json is "what treats MONDO:0005015", "treats Diabetes Mellitus" https://github.com/NCATSTranslator/Tests/blob/main/test_cases/TestCase_32.json

@colleenXu
Copy link

I'm not sure if the Test Case numbers listed in suites are supposed to correspond to the test case file names. @maximusunc ?

I've also noticed that the test case files have changed over time - so they aren't always the same input ID/corresponding asset set.

@maximusunc
Copy link
Collaborator

Technically, the Test Case numbers in the Test Suite should match the test case file names. But there have been some bugs in the spreadsheet ingestion script that caused them to change some. Going forward (now that the spreadsheet is deprecated), we should work on fixing any mismatches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants