Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Asset 599: bad answer ID for MPO, duplicate? #88

Closed
colleenXu opened this issue Jun 28, 2024 · 2 comments · Fixed by #95
Closed

Asset 599: bad answer ID for MPO, duplicate? #88

colleenXu opened this issue Jun 28, 2024 · 2 comments · Fixed by #95
Labels
Bad Asset Curie The given asset curie is not correct

Comments

@colleenXu
Copy link

Asset 599 currently uses CHEMBL.TARGET:CHEMBL2439 as the expected answer ID for MPO. However, CHEMBL.TARGET:CHEMBL2439 is likely something no ARA/KP recognizes. NodeNorm doesn't resolve this ID..

Instead, I wonder about using the conflated MPO (gene)/myeloperoxidase (protein) NCBIGene:4353.

But if we changed to that ID, this would be a duplicate of Asset 597. Similar to #87

Should this test be removed as a duplicate?
@colleenXu
Copy link
Author

Noted as a test all tools fail in #69

@maximusunc
Copy link
Collaborator

I agree that this should probably be removed as bad/duplicate.

@maximusunc maximusunc mentioned this issue Jul 12, 2024
Merged
@maximusunc maximusunc added the Bad Asset Curie The given asset curie is not correct label Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bad Asset Curie The given asset curie is not correct
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove bad asset for MPO NCATSTranslator/Tests
2 participants
@maximusunc @colleenXu