-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Asset 503: bad answer ID for thrombin/F2 gene #83
Comments
I think all tools have been consistently failing this test due to the answer ID. This asset is specifically described in #69 |
UniProtKB:P00734
the expected output ID/change the output name
Putting |
I don't agree with using prothrombin N-glycosylated 4 (human) / PR:000051041 as the CURIE. That looks like a very specific variation of prothrombin (N-glycosylated at Asn121) with very little literature on it. It may be worth asking the original writer of the test what ID to use? This is what I know:
|
please have a look at my response to #84 this is the way I worked with the tests assets: since I am testing the UI I report what the UI states. I think One asset can be a pass or a fail for several reasons (I used to express them but I am not sure the metadata was kept in the long run). Getting what the UI states is helpful to use those test assets for other suites (e.g. a normalization suite). |
Please assign this email address/GitHub account in the future, I do not receive any notification with the other one. Thanks! |
FWIW, Please note that currently NameRes does not allow the user to conflate or not. F2, prothrombin, and thrombin are currently in the same clique, which is what is expected for now. This may need to change if we need to unconflate though. |
Asset 503 says the expected output name is
UNIPROTKB:P00734
, which is the gene F2 + its proteins (Dev NodeNorm).However, the output ID
CHEMBL.TARGET:CHEMBL204
is likely something no ARA/KP recognizes. NodeNorm doesn't resolve this ID..I imagine the expected output ID needs to be changed to either
NCBIGene:2147
(the gene ID which is primary since we're doing gene-protein conflation) orUniProtKB:P00734
(note the corrected CURIE format). I imagine the name needs changing to "F2/prothrombin/thrombin" or something like that.The text was updated successfully, but these errors were encountered: