Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset 362: wrong answer ID for ACE inhibitors #76

Open
colleenXu opened this issue Jun 28, 2024 · 4 comments
Open

Asset 362: wrong answer ID for ACE inhibitors #76

colleenXu opened this issue Jun 28, 2024 · 4 comments
Labels
Bad Asset Curie The given asset curie is not correct Too General The asset is too general to be a good test

Comments

@colleenXu
Copy link

colleenXu commented Jun 28, 2024

Asset 362 says the expected output name is ACE inhibitors. However, the output ID PUBCHEM.COMPOUND:37056 is Ethyl4-ethoxy-6-methylnicotinate (Dev NodeNorm, PubChem).

Instead, BTE does return an Angiotensin-Converting Enzyme Inhibitors (UMLS:C0003015), although not in the top 10%.

If this test is kept, I imagine the expected output ID needs to be changed.
But I wonder if this test falls under the "too general" issue brought up in #64.

@maximusunc
Copy link
Collaborator

I'm not the best person to comment on generality, but Name Resolver returns UMLS:C3653768.

@maximusunc maximusunc added Bad Asset Curie The given asset curie is not correct Too General The asset is too general to be a good test labels Jul 12, 2024
@colleenXu
Copy link
Author

colleenXu commented Jul 16, 2024

It may be worth asking the original writer of the test what ID to use?


Also, Wikipedia includes the ID MESH:D000806. This is in NodeNorm Dev too - but its primary ID CHEBI:35457 appears to be a role, not really an entity...

@maximusunc
Copy link
Collaborator

I'm not sure who the original asset owner is.

@sandrine-muller-research

I am not the owner of this test but Angiotensin-converting-enzyme inhibitors (ACE) inhibitors is a whole class of compounds. The user expect the tool to answer a class of compounds which is not the question asked and the Translator response should be a given compound. Once getting the results, the user can select certain class of compounds so their need will be satisfied through UI interaction. For me this result is out of scope for this MVP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bad Asset Curie The given asset curie is not correct Too General The asset is too general to be a good test
Projects
None yet
Development

No branches or pull requests

3 participants