Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better/as good results/assets? #65

Closed
dkoslicki opened this issue Jun 27, 2024 · 6 comments
Closed

Better/as good results/assets? #65

dkoslicki opened this issue Jun 27, 2024 · 6 comments

Comments

@dkoslicki
Copy link
Member

Test 9 asset 618, has CHEBI:7772 omeprazole as a target top answer, ARAX returns esomeprazole CHEBI:50275 which seems like it should also count as correct

@maximusunc
Copy link
Collaborator

I'm a little confused by the results in the ARAX GUI. The first result header says omeprazole, but shows the curie for esomeprazole, but then result 3 is listed as esomeprazole with the same curie?

@dkoslicki
Copy link
Member Author

Yeah, that is odd (and likely our bug; I'm seeing that Omeprazole is correctly referenced in the edge bindings, but the node bindings swapped out that for Esomeprazole). But I was more indicating that both omeprazole and esomeprazole seem like equally good answers.

@maximusunc
Copy link
Collaborator

I would say that in the case that they're both equally good answers, you can add esomeprazole as an additional test asset. But it sounds like there isn't a question of whether or not Omeprazole is a good test asset to have. The test assets are finite, but we're always willing to add more for a more complete test bed.

@dkoslicki
Copy link
Member Author

Yup, sounds good! It's still head-scratching that no ARA got Omeprazole... will be interesting to see the various reasons as teams address these (us included)

@dkoslicki
Copy link
Member Author

Since it's marked as closed, did we/you want to add esomeprazole, or not at this point?

@maximusunc
Copy link
Collaborator

Opened a new issue: #70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants