Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can upload incorrect file to the wrong content type but can't delete #42

Open
jeffhhk opened this issue Jul 30, 2021 · 3 comments
Open
Assignees
Labels
September 2021 Relay September 2021 Relay bug fix / feature addition

Comments

@jeffhhk
Copy link
Contributor

jeffhhk commented Jul 30, 2021

Here I was confused about the order of operations and made a mistake:

image

I have files named both notes.tsv and edges.tsv uploaded to the KGX Content Type=edges field. Now I can't delete.

Here is what I did:

  1. Select KGX Content Type=nodes
  2. Browse to file and select nodes.tsv
  3. Click upload and wait
  4. When the upload was finished, nodes.tsv was still selected under "Browse..." but I was so surprised by this that I didn't notice at first
  5. Select on KGX Content Type=edges
  6. Thinking I was going to select a file, clicked on "Upload". What actually happened was that nodes.tsv was uploaded for a second time into the KGX Content Type=edges field.
    . . .

Possible solutions include:

  • Disallow multiple files to be allowed to one KGX Content Type
  • Allow a delete button
@RichardBruskiewich
Copy link
Collaborator

Thanks @jeffhhk, we have in mind to implement issue #36 which should provide a means of repairing incorrectly tagged uploaded files.

That said, we'll review the UI and upload code to see if the file type shouldn't just be inferred from the file name, since other software (e.g. KGX) constrains file content in that fashion (@kbruskiewicz we should take note of this)

@RichardBruskiewich
Copy link
Collaborator

Related to #22

It may be helpful for us to immediately enhance the upload form to all for repair of a file set in progress, or to redesign the form to make it more fool proof from end user faux pas.

@RichardBruskiewich RichardBruskiewich added the September 2021 Relay September 2021 Relay bug fix / feature addition label Sep 20, 2021
@jeffhhk
Copy link
Contributor Author

jeffhhk commented Sep 20, 2021

As a point of clarification, I would not expect the ability to delete after "Done Uploading" operation has taken place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
September 2021 Relay September 2021 Relay bug fix / feature addition
Projects
None yet
Development

No branches or pull requests

3 participants